Stuck on assignment

[cijagm]

Hello!
I am a 30 year old guy from sweden that are stuck on an assignment that are due in 2 days,
the assignment is to crypt a word to non letter word, and possible back to the original word
what's wrong with my code here it is:



#include <iostream>
#include <string>
#include <cstring>
#include <vector>
using namespace std;

string text(string a);

int main()
{
int x;
string ord;

cout<< "\nV\x84lj f\x94r kryptering\n1.Text till morse\n2.Morse till Text ";
cin>>x;
if(x==1)
cout<<"skriv in texten"<<endl;
cin>>ord;
cout<<"det krypterade ordet \x84r "<<text(ord);

system("PAUSE");
return 0;
}

string text(string a)
{
string z[30]={".-","-...","-.-.","-..",".","..-.","--.","....","..",".---"
,"-.-",".-..","--","-.","---",".--.","--.-",".-.","...","-"
,"..-","...-",".--","-..-","--..",".--.-",".-.-","---."};
string u[30]={"A","B","C","D","E","F","G","H","I","J","K","L","M","N","O"
,"P","Q","R","S","T","U","V","W","X","Y","Z","Å","Ä","Ö"};
string klart="";

for (int i = 0;i <a.size();i++)
{
char f =a [i];
for (int j = 0; j <=u.size();j++)
{
char g=u[j];
if(g==f)
}
klart=klart +z[i];

}

}
}
return klart;

[cijagm]

Please anyone help me

[VladimirF]

Your curly braces do not match (you have too many '}', so that your last return is outside of the function).
If you format your code properly, it will be easier to see.

[cijagm]

yeah that 1 curly bracers i forgot but still it's not working as it should be, if i dont use arrays[]
i get the code to work but the assignment is with arrays otherwise i cant store the signs.
ex string x [3]={"--","----","..."};-works
string y="--","----","..."; doesnt work
heres the code again


#include <iostream>
#include <string>
#include <cstring>
#include <vector>
using namespace std;

string text(string a);

int main()
{
int x;
string ord;

cout<< "\nV\x84lj f\x94r kryptering\n1.Text till morse\n2.Morse till Text ";
cin>>x;
if(x==1)
cout<<"skriv in texten"<<endl;
cin>>ord;
cout<<"det krypterade ordet \x84r "<<text(ord);

system("PAUSE");
return 0;
}

string text(string a)
{
string z[30]={".-","-...","-.-.","-..",".","..-.","--.","....","..",".---"
,"-.-",".-..","--","-.","---",".--.","--.-",".-.","...","-"
,"..-","...-",".--","-..-","--..",".--.-",".-.-","---."};
string u[30]={"A","B","C","D","E","F","G","H","I","J","K","L","M","N","O"
,"P","Q","R","S","T","U","V","W","X","Y","Z","Å","Ä","Ö"};
string klart="";

for (int i = 0;i <a.size();i++)
{
char f =a [i];
for (int j = 0; j <=u.size();j++)

char g=u[j];
if(g==f)
}
klart=klart +z[i];

}

}
}
return klart;
}

[ZuK]

        for (int j = 0; j <=u.size();j++)

u is just a plain c array. there is no such thing like size

you could use

        for (int j = 0; j <30 ;j++) {

and then

            char g=u[j];

That would be fine if you had declared u as an array of characters

You declared it as an array of strings

            char g=u[j][0];

would work

Kurt

[cijagm]

ok thx for that but now this code isnt working
if(g==f)

[ZuK]

Originally Posted by cijagm

ok thx for that but now this code isnt working
if(g==f)

That should work.
The brace after that is the wrong way round.
Kurt

[cijagm]

ok i got it to work but now it is writing out the entire z array instead of the corresponding one ex.
If i want to derypt the letter A it should compile it to ".-"

[ZuK]

I made just that 3 modifications and it works fine for me.
Kurt

[cijagm]

hmm
so if you want to crypt the word APE does it show:
.- .--. -

/cijagm

[ZuK]

There is another error

                klart=klart +z[i];

should be

                klart=klart +z[j];

my output

V�lj f�r kryptering
1.Text till morse
2.Morse till Text 1
skriv in texten
APE
det krypterade ordet �r .-.--..[Kurt@localhost Tests]$

Kurt

[cijagm]

hmm yeah that's right and i changed it to klart=klart +z[j];
but when i run it a pop up window from visualstudio show's up talking about a Just-In-Time Debugger ans asks me if i want toset the debugger as the selected default debugger
or manually choose the debugger engines.
very strange never happened b4-
/C

[hoxsiew]

Along with the brace fixes, I added the extra stuff in red:

#include <iostream>
#include <string>
#include <cstring>
#include <vector>
using namespace std;

string text(string a);

int main()
{
  int x;
  string ord;

  cout<< "\nV\x84lj f\x94r kryptering\n1.Text till morse\n2.Morse till Text ";
  cin>>x;
  if(x==1)
  {
    cout<<"skriv in texten"<<endl;
    cin>>ord;
    cout<<"det krypterade ordet \x84r "<<text(ord);
  }

  system("PAUSE");
  return 0;
}

string text(string a)
{
  char g;
  string z[30]={".-","-...","-.-.","-..",".","..-.","--.","....","..",".---"
    ,"-.-",".-..","--","-.","---",".--.","--.-",".-.","...","-"
    ,"..-","...-",".--","-..-","--..",".--.-",".-.-","---."};
  string u[30]={"A","B","C","D","E","F","G","H","I","J","K","L","M","N","O"
    ,"P","Q","R","S","T","U","V","W","X","Y","Z","Å","Ä","Ö"};
  string klart="";

  for (int i = 0;i <a.size();i++)
  {
    char f =a [i];
    for (int j = 0; j <=30;j++)
    {
      string tmp=u[j];
      g=tmp[0];
      if(g==f)
      {
        klart=klart +z[j]+" ";
        break;
      }
    }
  }

  return klart;
}

[ZuK]

Just noticed that there are only 29 non empty strings defined.
use

        for (int j = 0; j <29;j++) {

Kurt

[cijagm]

Thank you very much now it works , could you explain what u did? if it isn't to much to ask.
/C