string as parameter 1 of a class.. syntax?

[lemadness]

The overloaded constructer ( i think its called that) is like :

Player(string plclass,int mLvl,int mHP,int mMP,int mArmour,int mDmg)
{
plclass = plclass;
mLvl=mLvl;
mHP=mHP;
mMP=mMP;
mArmour=mArmour;
mDmg=mDmg;
}

and the first time i create one is

Player MyPlayer("dummy",10,1,2,4,5);

and then i mean to change the values of MyPlayer as the program goes on.

Whats happening is... there seems to be some kind of syntax problem with ("dummy",
. when the program is running - MyPlayer contains
plclass=""
and then massive negative integers for everything else

Im thinking the other values are getting filled with garbage because the string part is causing some error which spills into the other members... any help much appreciated..

[Skizmo]

Im thinking the other values are getting filled with garbage because the string part is causing some error which spills into the other members

Highly unlikely.

Put a breakpoint in the constructor, and check that it's actually called. If so, keep following the content of your variables to see if there are changed.

[ZuK]

Use names for the parameters that are different to the names of the class members or use the initializer list.
The parameter names shadow the members.
Kurt

[Skizmo]

Originally Posted by ZuK

Use names for the parameters that are different to the names of the class members or use the initializer list.
The parameter names shadow the members.
Kurt

Doh... that's the problem (that I didn't see that ).

You can do this too :

Player::plclass = plclass;

[Shadow_Govt]

I am wondering if it should llok more like this?

class Player
{

//Attributes should all have m in front in the class attributes (Not sure if it confuses it in your constructor?//

Private:
string mplclass;
int mLvl;
int mHP;
etc....

//Methods

Public:

Player( string plclass, int Lvl, int HP, int MP, int Armour, int Dmg);
};

Player::Player(string plclass,int Lvl,int HP,int MP,int Armour,int Dmg)
{
mplclass = plclass;
mLvl=Lvl;
mHP=HP;
mMP=MP;
mArmour=Armour;
mDmg=Dmg;
}

I dont know for sure if this will help. I am new to using classes. But it is worth a shot I say. Good Luck!

[lemadness]

Originally Posted by ZuK

Use names for the parameters that are different to the names of the class members or use the initializer list.
The parameter names shadow the members.
Kurt

Now that i have done this - My player function will take on the string parameter. half sorted thanks mate

However all the integers are still massive negatives.... I havent altered the numbers yet, they seem to just do that instead of being 10 or whatever i put there.

[ZuK]

Show the code.
Kurt

[lemadness]

got it. Was a shadowing issue. Thanks for the tip just had to double check everything twice.