DAO multi-threading tips

Download sample project

As stated by the MFC 4.2 documentation, the Dao database classes are not thread-safe, and that is indeed true.

I recently developed a server application the uses IO completion ports, which by nature, are using a number of threads. Because of that, I had to figure out a way to use DAO in different threads simultaneously. Here is how I did it:

//
// used a global critical section to prevent multiple threads initializing 
// the Dao database simultaneous.
//
CCriticalSection cs;

//
// Some thread function
// (In my server app, 4 thread using this function is started)
//
UINT MyThreadFunc (LPVOID pParam)
{
	CSingleLock lock(&cs, TRUE);

	//
	// Initialize MFC Dao support
	//
	AfxDaoInit();

	CDaoDatabase db;
	CSomeDaoRecordset set(&db);
	

	// 
	// Open the database and recordset.
	//
	try
	{
		db.Open(_T("database.mdb"));
		set.Open(dbOpenTable);
		set.SetCurrentIndex(_T("PrimaryKey"));
	}
	catch(CException* pe)	
	{
		pe->ReportError();
		pe->Delete();
		return 0;
	}

	//
	// Allow other threads to initialize Dao
	//
	lock.Unlock();
	

	//
	// OK the database and recordset is now open
	//

	while( bRunThisThread )
	{
		//
		// NOTE: You do NOT need to lock out other threads vhile calling
		// database functions here.
		//
		WaitForClientRequest();
		ParseRequest();
		DoDatabaseIO();
	}

	//
	// Now, lock the critical section again
	//
	lock.Lock();

	//
	// Close recordset and database.
	rs.Close();
	db.Close();

	// IMPORTANT: do NOT call AfxDaoTerm() !!!!
	return 0;
}

Now, when your application terminates, it will generate a protection error. To prevent that modify your CMyApp::ExitInstance().

int CMyApp::ExitInstance()
{
	// 
	// Insert your own cleanup code here
	//

	AfxDaoInit();
	AfxDaoTerm();
	
	return m_msgCur.wParam;
}

Notes:
7 The MFC documentation says the you need to call AfxBeginThread to start worker threads, but this is not necessary at all times, it depends on what your doing in your thread function. (I use both AfxBeginThread() and ::CreateThread()).
7 I call AfxBeginThread() in my main InitInstance() function, but I am not really sure if this is necessary. Of course, you should do it if you need to access the database from your main thread.
7 You will not gain true multithreaded access to the database functions. Jet 3.5 serializes the function calls, but the threads do not have to worry about that.

Known problems:
1. I have discovered that this approach can sometimes prevent other applications from starting, like MS Word 97, they simply hang, but when i shutdown my multithreaded Dao app, they continues as though nothing has happened ?????
2. My spelling :-)
3. ::CoInitialize() will be called for every call to AfxDaoInit(), and will not all be matched by a call to :: ::CoUninitialize(), but i hope the Windows will clean up the mess.