Bug in CreateRegion function in CPage.cpp

Posted by Legacy on 10/07/1998 12:00am

Originally posted by: manavesh ghosh

Original code :

CreateRegion(int ptop,int pleft,int pbottom,int pright)

{

	....

	....

   if (pRegion->Create(this,ptop,pleft,pright,pbottom)==FALSE)

  {

	....

	....

  }

}

 The if condition evaluated to false and consequently PrintForm1(CPage  *pPage) threw an exception.

  I modified the same to 

   if (pRegion->Create(this,ptop,pleft,pbottom,pright)==FALSE)

  

   and it worked fine.

  The code would have been robust if error checking for region creation

  is handled in PrintForm1(CPage *pPage) itself.

  CPrintRegion *Region2=pPage->CreateRegion(...);

  if (Region2!=NULL)

  {

   //  

  //

  }

Reply

Small bug found in CPrinter.cpp

Posted by Legacy on 10/01/1998 12:00am

Originally posted by: Frank Kobs

Problem:

CPage::Print returns the next row which can be used for positioning to the next line.

The return value of "Print" is not correct if empty strings are passed.

Solution:

Comment line 110 and 111 in CPrinter.cpp:
//if(strlen(ps->Text)==0)
// return 2 * ps->PointSize;

I have not tested for sideeffects, but it seems to work.

Regards,

Frank

Reply

Demo project missing .\res files

Posted by Legacy on 09/29/1998 12:00am

Originally posted by: Nick Alabaster

Project won't compile as download is without PrintDev.rc2, Toolbar.bmp, Doc.ico, PrintDev.ico. Simply copy and rename default versions into .\res and project compiles OK.

Reply

char fmt to const char fmt

Posted by Legacy on 09/28/1998 12:00am

Originally posted by: Frank Kobs

Dear Richard,

thanks for providing such a helpful class for printing!

I just used it for half an hour and find it really helpful...

Just one small improvement comes in my mind:
When you change the char *fmt to const char *fmt inside the ::Print declarations/bodies, You can also use the class with CStrings without any conversions.

With best regards,

Frank

Reply

Comments